network: don't fail if we can't read a connection associated with an active

It can happen in legitimate cases, such as a version incompatibility
between NetworkManager and libnm-glib or a restricted permission.

https://bugzilla.gnome.org/show_bug.cgi?id=701849

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 747b5a0b0b3975d21a8994b91a90a65c76830d9f..923aaeaf4c55a085364b72a9d5a2e89f91018822 100644 (file)
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1711,8 +1711,12 @@ const NMApplet = new Lang.Class({
 
             // Ignore slave connections
             let connectionPath = activeConnections[i].connection;
-            let connection = this._settings.get_connection_by_path(connectionPath)
-            if (this._ignoreConnection(connection))
+            let connection = this._settings.get_connection_by_path(connectionPath);
+
+            // connection might be null, if libnm-glib fails to create
+            // the object due to version incompatibility, or if the
+            // connection is not visible to the current user
+            if (connection && this._ignoreConnection(connection))
                 continue;
 
             supportedConnections.push(activeConnections[i]);